Skip to content

Conversation

@dkropachev
Copy link
Collaborator

@dkropachev dkropachev commented Nov 13, 2025

  1. Throw an exception on cluster initialization when concrete compression is configured, but library is not available
  2. Log an error only once at cluster initialization and disable compression if compression is True, but no library is available.
  3. Throw an exception on cluster initialization if compression is something else but string and bool

Pre-review checklist

  • I have split my patch into logically separate commits.
  • All commit messages clearly explain what they change and why.
  • I added relevant tests for new features and bug fixes.
  • All commits compile, pass static checks and pass test.
  • PR description sums up the changes and reasons why they should be introduced.
  • I have provided docstrings for the public items that I want to introduce.
  • I have adjusted the documentation in ./docs/source/.
  • I added appropriate Fixes: annotations to PR description.

@dkropachev dkropachev self-assigned this Nov 13, 2025
1. Throw an exception on cluster initialization when concrete compression is configured, but library is
   not available
2. Log an error only once at cluster initialization if compression is True, but no
   library is available.
3. Throw an exception on cluster initialization if compression is
   something else but string and bool
@dkropachev dkropachev force-pushed the dk/handle-compression-cases-better branch from 610e4d0 to dd68b45 Compare November 13, 2025 20:44
@dkropachev
Copy link
Collaborator Author

CICD failing due to known issue, which is not related to this PR.

@dkropachev dkropachev merged commit 78f5542 into scylladb:master Nov 16, 2025
10 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants